8000 Add the validated ID token and access token to the context so its claims can be used in mappers by ahus1 · Pull Request #37989 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the validated ID token and access token to the context so its claims can be used in mappers #37989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Add the validated ID token and access token to the context so its claims can be used in mappers #37989

merged 1 commit into from
Mar 14, 2025

Conversation

ahus1
Copy link
Contributor
@ahus1 ahus1 commented Mar 10, 2025

Closes #37988

@ahus1
Add the validated ID token and access token to the context so its cla…
ae974e1 
…ims can be used in mappers

Closes keycloak#37988

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 self-assigned this Mar 10, 2025
@ahus1
Copy link
Contributor Author
ahus1 commented Mar 10, 2025

@thomasdarimont - the build is running, still I'd like to you give a first feedback on this one and if it is a valid approach. It now mimics adding the ID and access token to the context if the validation is done using the user info endpoint.

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Mar 10, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
8000

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test06_addingUserToNewKeycloakGroup

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest.lambda$test06_addingUserToNewKeycloakGroup$26a8868a$3(LDAPGroupMapperTest.java:659)
...

Report flaky test

@ahus1 ahus1 marked this pull request as ready for review March 11, 2025 06:14
@ahus1 ahus1 requested review from a team as code owners March 11, 2025 06:14
@ahus1 ahus1 merged commit 1c9c9e3 into keycloak:main Mar 14, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mposolda mposolda mposolda approved these changes

Assignees

@ahus1 ahus1

Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For external-to-internal token exchange when using the userinfo endpoint, information from access or ID token can't be extracted
2 participants
@ahus1 @mposolda
0