-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Prevent frontend endpoint redirect to admin endpoint #38464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* @author Vaclav Muzikar <vmuzikar@redhat.com> | ||
*/ | ||
@KeycloakIntegrationTest(config = AdminRootTest.AdminUrlConfig.class) | ||
public class AdminRootTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if similar test exists in the old testsuite but seemed simpler to do it in the new one as we need to provide server config options. Let me know if that works for you.
@Override | ||
public LifeCycle getDefaultLifecycle() { | ||
return LifeCycle.GLOBAL; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a bit controversial but I assume we might need occasionally to provide some HTTP Client configs on the test level, hence the global scope would not work. Let me know if that works for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change this, instead add the compatible check based on annotations. That'll recreate the global instance as needed based on annotation config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointer. I didn't realize the compatible
method is there for this use case. Created #38586.
861a258
to
e02fb9a
Compare
ea5297a
to
796
8000
8b8f
Compare
Closes keycloak#38463 Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
7968b8f
to
2a52dff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #38463