Add locale attribute to the registration context #38549
Conversation
Closes keycloak#38029 Signed-off-by: rmartinc <rmartinc@redhat.com>
|
IMO the change is good. However I would like also the review from @keycloak/core-iam team as it is user-profile related issue. I have one concern though: In case that attribute |
|
@mposolda The |
Yes, that is what I can spot as well. Thanks for the clarification. If @keycloak/core-iam is fine with the PR, I hope we can merge. |
|
I first thought about adding a special |
There was a problem hiding this comment.
I think the approach makes sense and I have no objections to have this PR merged. I would just ensure @pedroigor gives his ack too.
|
@pedroigor @jonkoops @sguilhen Thanks everyone for the review! |
|
Hi all, Is it expected for users to check for required updates to their templates on every release themselves? |
|
@davidjbng - please open a bug issue and link it to this PR to discuss if there should be an addition to the migration guide, or if the implementation should change to be backwards compatible with other themes. |
Closes #38029
This PR adds the
localeattribute to the User Profile in the registration context. The idea is the registration page also sends the current locale of the user as another attribute of the registration. There have been several issues about the same so I think that it's better to add this attribute when internationalization is enabled in the realm. The theme just manages thelocaleattribute separately (exactly as the admin and account console are doing in UserProfileFields.tsx). The change is better checked hiding white-spaces (the ftl files are only adding an if-else and the big change is in indentation).It's a draft for the moment because it's a little change in behavior. But it's minor and I think that it's an improvement. WDYT? If accepted, do this need a release note?