Added ThemeManagerSpi and ported DefaultThemeManagerFactory to use it
#38592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mposolda
reviewed
Apr 2, 2025
There was a problem hiding this comment.
@xgp Thanks for the PR! It looks fine to me, but it will be good to consider this as an internal SPI (added 2 comments inline about it).
Also there are lots of test failures. I think it would be needed to register new SPI also to the file https://github.com/keycloak/keycloak/blob/main/server-spi-private/src/main/resources/META-INF/services/org.keycloak.provider.Spi in order to make it working.
server-spi/src/main/java/org/keycloak/theme/ThemeManagerSpi.java
Outdated
Show resolved
Hide resolved
server-spi/src/main/java/org/keycloak/theme/ThemeManagerFactory.java
Outdated
Show resolved
Hide resolved
Closes keycloak#38433. Signed-off-by: Garth <244253+xgp@users.noreply.github.com> Moved ThemeManagerSpi and ThemeManagerFactory to server-spi-private. Marked internal. Added to org.keycloak.provider.Spi file Signed-off-by: Garth <244253+xgp@users.noreply.github.com>
97d702a to
a7ac297
Compare
|
@mposolda Thanks for the feedback. Made all of your changes and pushed. I'm afraid my computer is too old to make running all the tests practical, so I'll watch the CI to see if it fixes the issues. |
mposolda
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38433.
Creates a
ThemeManagerFactoryas a proper SPI so that it can be accessed/overridden.Implementation
ThemeManagerSpiandThemeManagerFactoryDefaultThemeManagerFactoryimplementsThemeManagerFactoryDefaultKeycloakSessionFactorythat uses theDefaultThemeManagerFactory