10000 check for feature flags in Root.tsx's mapRoutes function by DevDuki · Pull Request #38816 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

check for feature flags in Root.tsx's mapRoutes function #38816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

check for feature flags in Root.tsx's mapRoutes function #38816

merged 1 commit into from
Apr 17, 2025

Conversation

DevDuki
Copy link
Contributor
@DevDuki DevDuki commented Apr 10, 2025

Closes #38783

@DevDuki DevDuki requested a review from a team as a code owner April 10, 2025 08:58
@edewit edewit force-pushed the make-routes-behind-isVisible-flags-unaccessible-when-flag-is-false branch from 84fa508 to 3c9010a Compare April 16, 2025 09:39
@edewit edewit enabled auto-merge (squash) April 16, 2025 09:39
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 16, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.url.HostnameV2Test#testAdminLocal

Keycloak CI - Base IT (6)

java.net.UnknownHostException: 127.0.0.1.nip.io: Temporary failure in name resolution
	at java.base/java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
	at java.base/java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:52)
	at java.base/java.net.InetAddress$PlatformResolver.lookupByName(InetAddress.java:1211)
	at java.base/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1828)
...

Report flaky test

@edewit
check for feature flags in Root.tsx's mapRoutes function before addin…
e378101 
…g a new menu item

Closes keycloak#38783

Signed-off-by: Dusan Misic <dusan.misic@inventage.com>
@edewit edewit force-pushed the make-routes-behind-isVisible-flags-unaccessible-when-flag-is-false branch from 3c9010a to e378101 Compare April 17, 2025 06:52
@edewit edewit merged commit be95c35 into keycloak:main Apr 17, 2025
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@edewit edewit edewit approved these changes

Assignees
No one assigned
Labels
flaky-test team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

content.json's isVisible flags are ignored in Root.tsx's mapRoutes function, which makes the pages still accessible
2 participants
@DevDuki @edewit
0