8000 Fix realm attributes example and correct HTTP method in OID4VCI docs by Awambeng · Pull Request #39409 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

Fix realm attributes example and correct HTTP method in OID4VCI docs #39409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

Fix realm attributes example and correct HTTP method in OID4VCI docs #39409

merged 2 commits into from
May 13, 2025

Conversation

Awambeng
Copy link
Contributor
@Awambeng Awambeng commented May 2, 2025 •
edited
Loading

This PR fixes outdated documentation in the OID4VCI configuration guide:

  • Moves preAuthorizedCodeLifespanS and issuerDid under the attributes section as required by the current schema.
  • Updates the curl command to use the correct HTTP method (PUT) for updating existing realms.

Closes #39264

@Awambeng
doc(oid4vc): fix: correct realm-attributes example and update HTTP me…
1603068 
…thod in docs

Moved 'preAuthorizedCodeLifespanS' and 'issuerDid' under 'attributes' to match current schema.
Updated curl example to use PUT instead of POST for updating existing realms.

Closes keycloak#39264

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
@Awambeng Awambeng requested a review from a team as a code owner May 2, 2025 09:18
@Awambeng Awambeng mentioned this pull request May 2, 2025
Closed
1 task
@mposolda mposolda self-assigned this May 5, 2025
@mposolda mposolda added the area/oid4vc Issue related to OpenID for Verifiable Credentials label May 7, 2025
mposolda
mposolda approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Awambeng Thanks!
Approving and merging based on @Captain-P-Goldfish review

@mposolda mposolda merged commit ea4ef74 into keycloak:main May 13, 2025
54 checks passed
@Awambeng Awambeng deleted the issue-39264 branch May 13, 2025 09:43
mposolda pushed a commit to mposolda/keycloak that referenced this pull request May 16, 2025
@Awambeng @mposolda
Fix doc(oid4vc): Correct realm-attributes example and update HTTP met…
6fa013e 
…hod in docs (keycloak#39409)

Closes keycloak#39264

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
(cherry picked from commit ea4ef74)
mposolda pushed a commit that referenced this pull request May 19, 2025
@Awambeng @mposolda
Fix doc(oid4vc): Correct realm-attributes example and update HTTP met…
768d802 
…hod in docs (#39409)

Closes #39264

Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
(cherry picked from commit ea4ef74)
@stianst stianst mentioned this pull request Jun 3, 2025
Merged
@ryanemerson ryanemerson mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposolda mposolda mposolda approved these changes

@Captain-P-Goldfish Captain-P-Goldfish Captain-P-Goldfish approved these changes

Assignees

@mposolda mposolda

Labels
area/oid4vc Issue related to OpenID for Verifiable Credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OID4VCI] Documentation Errors
3 participants
@Awambeng @mposolda @Captain-P-Goldfish
0