8000 Clarify podman use by andymunro · Pull Request #39422 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify podman use #39422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Clarify podman use #39422

merged 2 commits into from
May 5, 2025

Conversation

andymunro
Copy link
Contributor

Closes #39418

Copy link
Contributor
@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andymunro Thank you for the PR!

Comment on lines 131 to 134
[NOTE]
====
Podman can be used only for creating or customizing images. Podman is not supported in production environments.
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a note for downstream only? In upstream we certainly support Podman and Docker in production (if I recall our previous discussion about it).

CC @ahus1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. See below for suggestion that also clarifies the statement a bit with "Podman is not supported for running {project_name} in production environments."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Closes keycloak#39418

Signed-off-by: AndyMunro <amunro@redhat.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: andymunro <48995441+andymunro@users.noreply.github.com>
@ahus1 ahus1 merged commit d106de4 into keycloak:main May 5, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify when to use podman
3 participants
0