8000 feat: organization authenticator : bypass username form when login_hint is set by olivierboudet · Pull Request #39432 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: organization authenticator : bypass username form when login_hint is set #39432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

feat: organization authenticator : bypass username form when login_hint is set #39432

merged 1 commit into from
May 5, 2025

Conversation

olivierboudet
Copy link
Contributor

fixes #38228

when using organization authenticator, if login_hint is set, the username form should be auto submitted.

@olivierboudet olivierboudet requested a review from a team as a code owner May 4, 2025 20:49
@olivierboudet olivierboudet force-pushed the issue/38228 branch 2 times, most recently from 6d431b0 to 3af30a7 Compare May 4, 2025 21:31
@ahus1
Copy link
Contributor
ahus1 commented May 5, 2025

@olivierboudet - there seems to be a test failure that is related to your changes (at least when looking at the name of the failed test). Please review.

cc: @pedroigor and @sguilhen as this touches organisations.

@olivierboudet
feat: organization authenticator : bypass username form when login_hi…
04d6a6f 
…nt is set

Signed-off-by: Olivier Boudet <o.boudet@gmail.com>
@olivierboudet olivierboudet requested review from a team as code owners May 5, 2025 07:25
@olivierboudet
Copy link
Contributor Author

@olivierboudet - there seems to be a test failure that is related to your changes (at least when looking at the name of the failed test). Please review.

cc: @pedroigor and @sguilhen as this touches organisations.

Right, I fixed the test

sguilhen
sguilhen approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@sguilhen sguilhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahus1
ahus1 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @sguilhen's review.

@ahus1 ahus1 merged commit a39a64e into keycloak:main May 5, 2025
76 checks passed
@olivierboudet olivierboudet deleted the issue/38228 branch May 5, 2025 20:52
@olivierboudet
Copy link
Contributor Author

Thank you @ahus1, maybe this can be backported to next 26.2 patch release ?

@ahus1
Copy link
Contributor
ahus1 commented May 6, 2025

We usually don't backport enhancements, still I leave it for @sguilhen to make a judgement on this one.

Without getting ahead on things, it might be good if some people would try out the nightly build with this change and confirm that it is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguilhen sguilhen sguilhen approved these changes

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto submit the "Organization Identity-First Login" form with pre-filled username field
3 participants
@olivierboudet @ahus1 @sguilhen
0