-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix: don't treat quarkus property changes as hard errors #39459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI - There's the access denied error on Windows.
I'll have to copy to target instead then. |
closes: keycloak#39450 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins AFAIK, you could use even the |
Do you mean move it to a more common spot? The server module is currently a dependency of the junit logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Should we also backport it?
I don't see a risk, but it's also not a support scenario - and it's more likely users would be using environment variables, not the quarkus.properties for values that change at runtime. |
No, I just wanted to mention that we have already some kind of mechanism for copying files in the testsuite. But didn't check the requirements and stuff. LGTM :) |
) closes: keycloak#39450 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
) closes: keycloak#39450 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
) closes: keycloak#39450 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 071acce)
closes: #39450
It would be better to not directly modify the test resources conf diretory, but this change was a little more straight-forward than always creating / using a copy in the target directory.