8000 Refresh back button for chrome 136 (26.2) by rmartinc · Pull Request #39579 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refresh back button for chrome 136 (26.2) #39579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Refresh back button for chrome 136 (26.2) #39579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
< 8000 svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="anim-rotate"> Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/install-chrome/action.yml
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ inputs:
version:
description: The version of Chrome and Chromedriver to install. By default none is installed.
required: false
default: "135.0.7049.114" # E.g. 135.0.7049.84 (fixed version), default (chrome provided by GHA box)
default: default # E.g. 135.0.7049.84 (fixed version), default (chrome provided by GHA box)

runs:
using: composite
Expand Down Expand Up @@ -36,4 +36,4 @@ runs:
shell: bash
run: |
google-chrome --version
$CHROMEWEBDRIVER/chromedriver --version
$CHROMEWEBDRIVER/chromedriver --version
19 changes: 19 additions & 0 deletions .../integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/util/UIUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import org.apache.commons.lang3.StringUtils;
import org.junit.Assert;
import org.keycloak.testsuite.page.AbstractPatternFlyAlert;
import org.keycloak.testsuite.pages.AbstractPage;
import org.openqa.selenium.By;
import org.openqa.selenium.JavascriptExecutor;
import org.openqa.selenium.Keys;
Expand Down Expand Up @@ -311,4 +312,22 @@ public static String getRawPageSource(WebDriver driver) {
public static String getRawPageSource() {
return getRawPageSource(getCurrentDriver());
}

/**
* Navigates the driver back but it refreshes the page if it is not the expected one for
* chrome. Chrome 136 does not respect cache-control and refresh is needed
* to reach the server again (the page is cached no matter the cache-control
* directive returned).
* See https://issues.chromium.org/issues/415773538
*
* @param driver The driver used
* @param expectedPage The expected page
*/
public static void navigateBackWithRefresh(WebDriver driver, AbstractPage expectedPage) {
driver.navigate().back();
if (!expectedPage.isCurrent() && BrowserDriverUtil.isDriverChrome(driver)) {
driver.navigate().refresh();
}
expectedPage.assertCurrent();
}
}
16 changes: 6 additions & 10 deletions ...-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/BrowserButtonsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.keycloak.testsuite.pages.VerifyEmailPage;
import org.keycloak.testsuite.util.GreenMailRule;
import org.keycloak.testsuite.util.MailUtils;
import org.keycloak.testsuite.util.UIUtils;
import org.keycloak.testsuite.util.UserBuilder;

/**
Expand Down Expand Up @@ -150,8 +151,7 @@ public void requiredActionsBackForwardTest() throws IOException, MessagingExcept
updateProfilePage.assertCurrent();

// Click browser back. Assert on "Page expired" page
driver.navigate().back();
loginExpiredPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, loginExpiredPage);

// Click browser forward. Assert on "updateProfile" page again
driver.navigate().forward();
Expand Down Expand Up @@ -182,8 +182,7 @@ public void requiredActionsBackAndRefreshTest() throws IOException, MessagingExc
updateProfilePage.assertCurrent();

// Click browser back. Assert on "Page expired" page
driver.navigate().back();
loginExpiredPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, loginExpiredPage);

// Click browser refresh. Assert still on "Page expired" page
driver.navigate().refresh();
Expand All @@ -198,8 +197,7 @@ public void requiredActionsBackAndRefreshTest() throws IOException, MessagingExc
updateProfilePage.assertCurrent();

// Click browser back. Assert on "Page expired" page
driver.navigate().back();
loginExpiredPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, loginExpiredPage);

// Click "login continue" and assert on updateProfile page
loginExpiredPage.clickLoginContinueLink();
Expand All @@ -226,8 +224,7 @@ public void consentRefresh() {
grantPage.assertCurrent();

// Click browser back. Assert on "page expired"
driver.navigate().back();
loginExpiredPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, loginExpiredPage);

// Click continue login. Assert on consent screen again
loginExpiredPage.clickLoginContinueLink();
Expand Down Expand Up @@ -363,8 +360,7 @@ public void appInitiatedRegistrationWithBackButton() throws Exception {
updatePasswordPage.assertCurrent();

// Click browser back. Should be on 'page expired'
driver.navigate().back();
loginExpiredPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, loginExpiredPage);

// Click 'continue' should be on updatePasswordPage
loginExpiredPage.clickLoginContinueLink();
Expand Down
4 changes: 2 additions & 2 deletions ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/RegisterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import org.keycloak.testsuite.util.oauth.AccessTokenResponse;
import org.keycloak.testsuite.util.UserBuilder;
import org.keycloak.testsuite.util.AccountHelper;
import org.keycloak.testsuite.util.UIUtils;

import jakarta.mail.internet.MimeMessage;
import jakarta.ws.rs.core.Response;
Expand Down Expand Up @@ -904,9 +905,8 @@ public void testRegisterShouldFailBeforeUserCreationWhenUserIsInContext() {
driver.navigate().back();
driver.navigate().back();
events.clear();
driver.navigate().back();

errorPage.assertCurrent();
UIUtils.navigateBackWithRefresh(driver, errorPage);
Assert.assertEquals("Action expired. Please continue with login now.", errorPage.getError());

events.expectRegister("registerUserMissingTermsAcceptance", "registerUserMissingTermsAcceptance@email")
Expand Down
Loading
0