Display POST and REDIRECT bindings in the SPSSODescriptor for the SAML IDP provider #39796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L IDP provider Closes keycloak#39596 Signed-off-by: rmartinc <rmartinc@redhat.com>
pedroigor
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39596
Little PR to display both POST and REDIRECT bindings in the SAML IDP provider metadata (SingleLogoutService and AssertionConsumerService). Previously one or the other was shown depending the options selected in the configuration. But that behavior does not make much sense as both bindings are available and working, and therefore they can be used by the server. The configuration options are more to what binding the provider will use to login or logout when sending the request to the remote server. The PR just maintains the order as before using the options, but both methods (and artifact that was added later for the assertion consumer) are shown.
@keycloak/core-iam Take a look when you have time.