8000 Revise DPoP Codes - refactor remove unused methods by tnorimat · Pull Request #39827 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revise DPoP Codes - refactor remove unused methods #39827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Revise DPoP Codes - refactor remove unused methods #39827

merged 1 commit into from
May 20, 2025

Conversation

tnorimat
Copy link
Contributor

closes #39826

@tnorimat tnorimat requested a review from a team as a code owner May 20, 2025 06:42
@tnorimat
Revise DPoP Codes - refactor remove unused methods
5ed7700 
closes keycloak#39826

Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed May 20, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testNoFailureResetForPermanentLockout

Keycloak CI - Base IT (5)

java.lang.AssertionError: 
type
Expected: is "LOGIN_ERROR"
     but: was "USER_DISABLED_BY_PERMANENT_LOCKOUT"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@mposolda mposolda self-assigned this May 20, 2025
mposolda
mposolda approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat Thanks!

@mposolda mposolda merged commit c0b2c1f into keycloak:main May 20, 2025
76 checks passed
@tnorimat tnorimat deleted the ISSUE-39826 branch May 21, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revise DPoP Codes - refactor remove unused methods
2 participants
@tnorimat @mposolda
0