Make recovery codes supported #39017
Merged
+19
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
previously approved these changes
Apr 16, 2025
graziang
approved these changes
Apr 16, 2025
|
@rmartinc LGTM, but PR will need some small update to fix the conflicts. |
Closes keycloak#38994 Signed-off-by: rmartinc <rmartinc@redhat.com>
|
Rebased! |
mposolda
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38994
PR to make recovery codes supported. Added a note in the documentation, removed the preview warning in the server admin section and updated the tests to not enable the feature. I moved the priority to the next 110 as it seems that priorities are spaced by 10 (tests check that). Also updated the authenticator to add the action to the session is the user is read-only.