8000 Change Grafana dashboards guide title to plural by mhajas · Pull Request #39052 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change Grafana dashboards guide title to plural #39052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

mhajas
Copy link
Contributor
@mhajas mhajas commented Apr 17, 2025

Closes #39057

@ahus1 While writing the blog post I found the name in singular a little odd to read. I think it makes more sense with plural.

Let me know what you think and if it makes sense to you, I will create an issue for this.

Signed-off-by: Michal Hajas <mhajas@redhat.com>
@ahus1
Copy link
Contributor
ahus1 commented Apr 17, 2025

As of today we only have a single dashboard with multiple graphs, so I think the current version of the docs is correct.

The title can still be changed to plural. Please go ahead. And thank you for fixing the other typo.

@ahus1
Copy link
Contributor
ahus1 commented Apr 17, 2025

@mhajas - ok, I stand corrected, there are two dashboards already. Then it makes even more sense.

@mhajas mhajas marked this pull request as ready for review April 17, 2025 13:16
@mhajas mhajas requested a review from a team as a code owner April 17, 2025 13:16
@mhajas mhajas merged commit 922294c into keycloak:main Apr 17, 2025
54 checks passed
@mhajas mhajas deleted the update-dashboards-guide-title branch April 17, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the title for Grafana dashboards guide to plural
2 participants
0