Make distribution startup timeout configurable #39143
Conversation
There was a problem hiding this comment.
Thanks for the PR!
Having configurable timeout might seem handy, however I wonder if it's the best approach for our CIs. Since we do not want to have code differences in our repos, this would have to be hooked up to some GHA variable (so it's configured at the repo settings level and not on the code / workflow definition level).
I wonder if it wouldn't be simpler to just increase the timeout so it works for all our repos / CI envs?
Ok, if we'd like to minimize code differences, I'd vote to set the different timeout only for the store integration tests. As the RawKeycloakDistribution is used in many places where we do not expect big startup delays, it might bring some additional tradeoffs. To be more specific, if there's an issue at the startup, we wait much longer for the server and the overall CI spent time is much bigger. |
Closes keycloak#39142 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
|
@vmuzikar Does it work for you to have changes like in the current state of this PR? |
Closes #39142
@keycloak/cloud-native Could you please check it? Thanks!