10000 Make user attribute option for SAML mappers required by rmartinc · Pull Request #39184 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make user attribute option for SAML mappers required #39184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Make user attribute option for SAML mappers required #39184

merged 1 commit into from
Apr 25, 2025

Conversation

rmartinc
Copy link
Contributor

Closes #37648

The PR just adds the required attribute and the user profile list type to the user attribute in the three SAML mappers. But I detected that the ⚠ Required field error message was not displayed in the UI because the errors variable has an intermediate config key and it's not detected in the array errors[convertedName!]. I just fixed that doing a quick fix, please @keycloak/ui check if you see something better for this.

@rmartinc rmartinc requested review from a team as code owners April 24, 2025 13:07
mposolda
mposolda previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but will require from UI team.

@rmartinc
Make user attribute option for SAML mappers required
3794647 
Closes keycloak#37648

Signed-off-by: rmartinc <rmartinc@redhat.com>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 25, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 24)

org.openqa.selenium.NoSuchElementException: 
Unable to locate element
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2022', os.arch: 'amd64', os.version: '10.0', java.version: '24.0.1'
...

Report flaky test

ahus1
ahus1 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews

@ahus1 ahus1 merged commit f05f602 into keycloak:main Apr 25, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

@ahus1 ahus1 ahus1 approved these changes

@mposolda mposolda mposolda left review comments

Assignees
No one assigned
Labels
flaky-test team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Attribute option of SAML "User Attribute Mapper for NameID" should be required
4 participants
@rmartinc @jonkoops @mposolda @ahus1
0