Add OpenAPI annotation to JSON object of ClientPolicycy representations #39240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#32600 Signed-off-by: Tetsuhiro Hiruta <tetsuhiro.hiruta.sg@hitachi.com>
|
@hrttthr Hello, thank you for the PR. It seems that the PR lacks its integration tests. Could you tell me the reaon why? or simply miss to implement the test? |
|
@tnorimat Thank you for your review. This PR only adds annotations to modify the OpenAPI specification. Therefore, I think it does not affect the operation and does not require testing. |
|
@hrttthr Thank you for the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI specification error of missing items, which occurred because the variable configuration was an array type, has been resolved by making configuration an object type.
Closes #32600