8000 Improve metadata for Recovery Codes by rmartinc · Pull Request #39311 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve metadata for Recovery Codes #39311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Improve metadata for Recovery Codes #39311

merged 1 commit into from
Apr 29, 2025

Conversation

rmartinc
Copy link
Contributor

Closes #39243

Improvements to the recovery codes data commented in #39243:

  1. The algorithm is now SHA-512.
  2. Iterations is set to null to not be returned.
  3. The title is using Data for credential {{label}}.

Image for a new recovery codes credential:
Screenshot From 2025-04-29 08-34-00

Image for an old recovery codes credential:
Screenshot From 2025-04-29 08-34-19

@rmartinc rmartinc requested review from a team as code owners April 29, 2025 06:38
@mposolda mposolda self-assigned this Apr 29, 2025
mposolda
mposolda previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks, approving! I've added one suggestion inline for adding the comment, but likely not a blocker for the PR

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 29, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#categoriesTest

Keycloak CI - WebAuthn IT (firefox)

java.lang.AssertionError: 

Expected: is <2>
     but: was <0>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

mposolda
mposolda previously approved these changes Apr 29, 2025
View reviewed changes
@rmartinc
Improve metadata for Recovery Codes
d1ad276 
Closes keycloak#39243

Signed-off-by: rmartinc <rmartinc@redhat.com>
@mposolda mposolda merged commit 887c2c2 into keycloak:main Apr 29, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels
flaky-test team/cloud-native team/core-clients team/core-iam team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we improve metadata of recovery code credential?
3 participants
@rmartinc @jonkoops @mposolda
0