8000 [OID4VCI] Always Return Array for Credential Responses by forkimenjeckayang · Pull Request #40409 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[OID4VCI] Always Return Array for Credential Responses #40409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2025
Merged

[OID4VCI] Always Return Array for Credential Responses #40409

merged 5 commits into from
Jul 7, 2025

Conversation

forkimenjeckayang
Copy link
Contributor

This PR updates the Keycloak OID4VCI implementation to comply with the latest OID4VCI specification, ensuring that the credentials field in the credential response is always an array (even for a single credential).

  • CredentialResponse Model:

    • Updated to ensure credentials is always a list of credential objects.
    • Removed/avoided any usage of single credential fields.

  • Issuer Endpoint:

    • Ensured that immediate issuance always returns an array of credentials.

Closses Ticket

@forkimenjeckayang
Always Return Array of Credentilas for Credential Responses
fe22773 
Closes keycloak#39283

Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
@forkimenjeckayang forkimenjeckayang requested review from a team as code owners June 11, 2025 10:59
@forkimenjeckayang forkimenjeckayang mentioned this pull request Jun 11, 2025
Closed
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.ClientScopeInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 11, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

Captain-P-Goldfish
Captain-P-Goldfish approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor
@Captain-P-Goldfish Captain-P-Goldfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

mposolda
mposolda approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forkimenjeckayang @Captain-P-Goldfish @francis-pouatcha Thanks for the PR and the review!

@mposolda mposolda self-assigned this Jul 7, 2025
@mposolda mposolda merged commit 178b893 into keycloak:main Jul 7, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mposolda mposolda mposolda approved these changes

6518 @francis-pouatcha francis-pouatcha francis-pouatcha approved these changes

@Captain-P-Goldfish Captain-P-Goldfish Captain-P-Goldfish approved these changes

Assignees

@mposolda mposolda

Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forkimenjeckayang @mposolda @francis-pouatcha @Captain-P-Goldfish
0