8000 [OID4VCI] Remove interval property from Credential Offer by forkimenjeckayang · Pull Request #40412 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[OID4VCI] Remove interval property from Credential Offer #40412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2025
Merged

[OID4VCI] Remove interval property from Credential Offer #40412

merged 5 commits into from
Jul 7, 2025

Conversation

forkimenjeckayang
Copy link
Contributor
@forkimenjeckayang forkimenjeckayang commented Jun 11, 2025 •
edited
Loading

This pull request addresses the recent specification change in OpenID for Verifiable Credential Issuance (OID4VCI), where the interval property was moved from the Credential Offer to the Deferred Credential Response.

To align with the updated specification, this change removes the interval property from the PreAuthorizedCode model, which is part of the Credential Offer payload.

Changes:

  • Removed the interval field and its corresponding getter and setter methods from PreAuthorizedCode.java.
  • Updated the equals() and hashCode() methods in PreAuthorizedCode.java to reflect the removal of the interval property.
  • Verified that no existing tests were impacted by this change, ensuring the continued stability of the test suite.

Closes #39294

@forkimenjeckayang
Remove interval property from Credential Offer
01af265 
Closes keycloak#39294

Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
@forkimenjeckayang forkimenjeckayang requested a review from a team as a code owner June 11, 2025 11:17
@forkimenjeckayang forkimenjeckayang mentioned this pull request Jun 11, 2025
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 11, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.GroupInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

org.keycloak.testsuite.cluster.UserInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

Captain-P-Goldfish
Captain-P-Goldfish approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor
@Captain-P-Goldfish Captain-P-Goldfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jun 30, 2025
Open
mposolda
mposolda approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forkimenjeckayang @Captain-P-Goldfish @francis-pouatcha Thanks for the PR and review

@mposolda mposolda self-assigned this Jul 7, 2025
@mposolda mposolda merged commit 2aca97b into keycloak:main Jul 7, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mposolda mposolda mposolda approved these changes

@francis-pouatcha francis-pouatcha francis-pouatcha approved these changes

@Captain-P-Goldfish Captain-P-Goldfish Captain-P-Goldfish approved these changes

Assignees

@mposolda mposolda

Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OID4VCI] Remove reference to an interval property in Credential Offer payloads
4 participants
@forkimenjeckayang @mposolda @francis-pouatcha @Captain-P-Goldfish
0