Additional Quarkus devtools dependencies in distribution #40458
Conversation
Closes keycloak#39227 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
|
Based on the info in #39227 Before: After: |
This all makes sense. Just wondering about the warning - who will be looking at that, and / or should it be an error instead? |
|
@shawkins Thanks for the review!
At least we in our team who quite often build the Quarkus distribution as we might clearly see if the list is wider than before (IMHO better than not checking it at all).
As we cannot remove all these dev dependencies for now, I would not vote for hard error and build failure. It's even better to only warn about the usage of dev dependencies for the project https://github.com/mabartos/keycloak-quarkus-extensions, where people can add some additional dev dependencies intentionally. But if we decide to not add any checker, I'm ok with that, but we'd need some other approach to check it to prevent these issues again. |
As discussed offline, the main problem with the dev dependencies is prod related. And that problem is not specific to the dev dependencies only – there are others which this script won't catch. So it somewhat helps but it's not the ultimate solution for that. We'll still need to consult our internal prod reports. That said, it was not a blocker for me and it's ok from my perspective to keep the script, albeit it adds some time when building. No need to revert that as it's merged now. :) |
Closes #39227
io.quarkus:quarkus-devtools-commoncannot be excluded from the distribution, but its transitive dependencies can@shawkins @vmuzikar Could you please check it? Thanks!