8000 kyrgyz language support by babdikaarov · Pull Request #40473 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

kyrgyz language support #40473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

kyrgyz language support #40473

merged 2 commits into from
Jun 16, 2025

Conversation

babdikaarov
Copy link
Contributor
@babdikaarov babdikaarov commented Jun 13, 2025 •
edited by ahus1
Loading

🇰🇬 Kyrgyz Language Support (ky)

This pull request introduces Kyrgyz language support (ky) for the Keycloak UI and related themes.

📝 Summary

This PR adds support for the ky locale by:

  • Adding new Kyrgyz translation files for various Keycloak themes.
  • Registering the new locale in relevant theme property files.

🔧 Changed Files

✏️ Modified - 5 files

  • themes/src/main/resources-community/theme/base/account/theme.properties
  • js/apps/account-ui/test/personal-info/user-profile.json
  • themes/src/main/resources-community/theme/base/admin/theme.properties
  • themes/src/main/resources-community/theme/base/email/theme.properties
  • themes/src/main/resources-community/theme/base/login/theme.properties

📄 Created - 6 files

  • js/apps/account-ui/maven-resources-community/theme/keycloak.v3/account/messages/messages_ky.properties
  • js/apps/admin-ui/maven-resources-community/theme/keycloak.v2/admin/messages/messages_ky.properties
  • themes/src/main/resources-community/theme/base/account/messages/messages_ky.properties
  • themes/src/main/resources-community/theme/base/admin/messages/messages_ky.properties
  • themes/src/main/resources-community/theme/base/email/messages/messages_ky.properties
  • themes/src/main/resources-community/theme/base/login/messages/messages_ky.properties

📢 Call for Review

I would like to invite native Kyrgyz speakers to review and verify the accuracy of these translations.

🔗 Related Issue

Closes #40448

@babdikaarov
kyrgyz language support
e3f1599 
Signed-off-by: Beksultan A <babdikaarov@gmail.com>
@babdikaarov babdikaarov requested review from a team as code owners June 13, 2025 11:39
Elkhan2003
Elkhan2003 approved these changes Jun 13, 2025
View reviewed changes
Copy link
@Elkhan2003 Elkhan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Everything looks good. The translations are accurate and clear.
I approve these changes.

ahus1
ahus1 requested changes Jun 13, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change and adding the new language!
There are some small changes I would like to see below.
As the translation itself has already been review, add those changes as an additional commit.
@ahus1 ahus1 self-assigned this Jun 13, 2025
@babdikaarov
fix: undo reformat .json, sequance order of language
395499c 
Signed-off-by: Beksultan A <babdikaarov@gmail.com>
@babdikaarov
Copy link
Contributor Author

Dear @ahus1

Thanks for your attention to this pull request.

As requested the changes have been made:

  • reformating .json file updated up to standard of (printWidth: 80, tabWidth: 2)
  • the theme.properties language sequence properly ordered.

The changes have been pushed — awaiting approval to merge.

@ahus1 ahus1 enabled auto-merge (squash) June 14, 2025 18:56
@ahus1
Copy link
Contributor
ahus1 commented Jun 14, 2025

Thank you for the PR, I reviewed it and tested it locally. It looks good to me.

Pinging the @keycloak/ui team to review it as well to approve it.

@babdikaarov
Copy link
Contributor Author

Dear @ahus1,

I am glad and appreciate that you have referenced this PR for the next step ui verification.

Looking forward for the approval

@ahus1 ahus1 merged commit 160ec6b into keycloak:main Jun 16, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssilvert ssilvert ssilvert approved these changes

@ahus1 ahus1 ahus1 approved these changes

@Elkhan2003 Elkhan2003 Elkhan2003 approved these changes

Assignees

@ahus1 ahus1

Labels
team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add (ky )kyrgyz language support
4 participants
@babdikaarov @ahus1 @ssilvert @Elkhan2003
0