8000 Missing Quarkus flag for Syslog counting framing by mabartos · Pull Request #40621 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Missing Quarkus flag for Syslog counting framing #40621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2025
Merged

Missing Quarkus flag for Syslog counting framing #40621

merged 3 commits into from
Jun 25, 2025

Conversation

mabartos
Copy link
Contributor
@mabartos mabartos commented Jun 19, 2025 •
edited
Loading

The property is added in this PR, which contains smarter decisions based on the used protocol same as Quarkus will do once we upgrade to the newer version (not backported to 3.20.x): quarkusio/quarkus#48479

Once we upgrade Quarkus, we can remove the handling of the protocol-dependent strategy.

@keycloak/cloud-native-maintainers Could you please check it? Thanks!

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 19, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailover

Keycloak CI - Store IT (mysql)

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@mabartos mabartos marked this pull request as ready for review June 23, 2025 14:02
@mabartos mabartos requested review from a team as code owners June 23, 2025 14:02
@mabartos mabartos force-pushed the KC-39893 branch 2 times, most recently from 8219254 to 956183c Compare June 23, 2025 14:09
@mabartos mabartos mentioned this pull request Jun 23, 2025
Closed
shawkins
shawkins reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor
@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabartos looks good, just one thought on the usage of mapFrom in this case.

mabartos added 2 commits June 24, 2025 10:58
@mabartos
Missing Quarkus flag for Syslog counting framing
9117ec6 
Closes keycloak#39893

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Remove handling of mapFrom
f6c9a0a 
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Copy link
Contributor Author

@shawkins Ready for another review.

cc: @vmuzikar @Pepo48

shawkins
shawkins previously approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mabartos
8000

@mabartos
Add notable change
a8174f2 
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Copy link
Contributor Author

@shawkins Added the notable change for 26.3.0

@mabartos mabartos mentioned this pull request Jun 24, 2025
Open
@mabartos mabartos self-assigned this Jun 24, 2025
shawkins
shawkins approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabartos
Copy link
Contributor Author

@vmuzikar Could you please review/approve this PR once you have a time? Thanks!

vmuzikar
vmuzikar approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor
@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vmuzikar vmuzikar merged commit d475c5a into keycloak:main Jun 25, 2025
80 checks passed
This was referenced Jun 27, 2025
Open
Open
shawkins pushed a commit to shawkins/keycloak that referenced this pull request Jul 1, 2025
@mabartos @shawkins
Missing Quarkus flag for Syslog counting framing (keycloak#40621)
3058501 
* Missing Quarkus flag for Syslog counting framing

Closes keycloak#39893

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

* Remove handling of mapFrom

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

* Add notable change

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

---------

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@shawkins shawkins shawkins approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

Assignees

@mabartos mabartos

Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Quarkus flag for syslog logging
3 participants
@mabartos @shawkins @vmuzikar
0