Move section in the upgrading guide #40735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#39063 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
c69120c to
d8f9e58
Compare
vmuzikar
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
@ahus1 Thank you for the PR.
I'm not sure I'd say this is a deprecation note. We've introduced a new format while effectively deprecating the old. So it's kinda a new feature and a deprecation. A notable change sounds more descriptive to me, though I don't have a strong opinion about it, so approving regardless.
|
@vmuzikar - I hear you. AFAIK there isn't yet a warning for all SPI options in the old format, and we also don't provide a note that all SPI options (regardless if their suffix is for "enabled" or one of the other special ones). With putting this section into the "deprecated" area, it is now official that we're eventually stop supporting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39063
This moves the section as it is IMHO not a notable change, but a deprecation. As we would eventually remove support for the old format, this is IMHO the right section.