Implement a new impersonation flow that uses action tokens #40767
+535
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
5d9238a to
684fe84
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
684fe84 to
4d22240
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
|
I'm switching this PR to draft while the build is failing to allow maintainers to unsubscribe. Please ping individual maintainer (including me) if you need help. |
5811d25 to
9599fb5
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
9599fb5 to
2e74209
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
|
Thanks and sorry for notification spam, I didn't think about that. Will try to remember that. Anyway, I should be done by now and am happy to receive feedback. |
| @@ -116,4 +116,11 @@ default Predicate<? super T>[] getVerifiers(ActionTokenContext<T> tokenContext) | |||
| * @return see above | |||
| */ | |||
| boolean canUseTokenRepeatedly(T token, ActionTokenContext<T> tokenContext); | |||
|
|
|||
| /** | |||
| * Returns {@code true} when a validity check needs to be beformed before invoking the action, {@code false} when | |||
| @@ -28,6 +28,7 @@ loginTitle=Sign in to {0} | |||
| loginTitleHtml={0} | |||
| impersonateTitle={0} Impersonate User | |||
| impersonateTitleHtml=<strong>{0}</strong> Impersonate User | |||
| impersonateError=Error happend while impersonating user | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new flow impersonation flow that uses action tokens.
Previously, the impersonation endpoint immediately creates an identity cookie and returns that to the Browser. This has a couple of downsides:
In this implementation with action tokens, the impersonation will happen once the returned redirect URI is opened in a browser, removing the limitations.
Fixes #10655