8000 Fallback to display text consent scopes by SferaDev · Pull Request #40789 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fallback to display text consent scopes #40789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fallback to display text consent scopes #40789

wants to merge 1 commit into from
+2 −1

Conversation

SferaDev
Copy link
Contributor
@SferaDev SferaDev commented Jun 30, 2025 •
edited
Loading

Closes #40788

image

SebastEnn
SebastEnn reviewed Jun 30, 2025
View reviewed changes
@SferaDev
Fallback to display text consent scopes
3b59125 
Closes keycloak#40788

Signed-off-by: Alexis Rico <sferadev@gmail.com>
8000 @SferaDev SferaDev changed the title Show consent display text in account settings ui Fallback to display text consent scopes Jun 30, 2025
@SferaDev SferaDev marked this pull request as ready for review June 30, 2025 15:29
@SferaDev SferaDev requested review from a team as code owners June 30, 2025 15:29
@SferaDev SferaDev requested a review from SebastEnn June 30, 2025 15:44
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 30, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPReadOnlyTest#testReadOnlyUserGetsPermanentlyLocked

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

SebastEnn
SebastEnn reviewed Jul 1, 2025
View reviewed changes
js/apps/account-ui/src/applications/Applications.tsx
@@ -216,7 +216,8 @@ export const Applications = () => {
</DescriptionListTerm>
{application.consent.grantedScopes.map((scope) => (
<DescriptionListDescription key={`scope${scope.id}`}>
<CheckIcon /> {t(scope.name as TFuncKey)}
<CheckIcon />{" "}
{t(scope.name as TFuncKey, scope.displayTest)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added scope.displayTest (typo intended) as a second argument. The string behind it will be displayed if no translation for the first argument has been found.
Can you explain what the idea behind this is? Maybe with example cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the case is when defining a custom scope that is not built-in in Keycloak and has not been added as a translation in the realm settings.

You can find a picture in the PR description with one case

@mposolda mposolda assigned mposolda and unassigned mposolda Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastEnn SebastEnn SebastEnn left review comments

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
flaky-test team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom scope display name not shown in Account UI
3 participants
@SferaDev @SebastEnn @mposolda
0