-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix: streamlining the client scope update #40808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
closes: keycloak#40805 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins thank you for taking the time I really appreciate it. |
For me using ~250 simple realms like your script created it cut the import time by about 35%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you
@shawkins I can confirm this reduces import-realm duration from 49sec to 35sec when you have ~1000 realms. |
Based upon the review from @yelhouti I'll go ahead and merge this - actually still need a review from @keycloak/maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @vramik's review
-1 as it is a performance optimization only, and the cost of backporting and potential breakage is IMHO not worth it. If any, only backport it to 26.3. Backporting might help in catching regressions and making the person reporting it happy. |
Prevents the client scope update logic from deleting, then re-adding the same client scope.
closes: #40805
cc @yelhouti