8000 fix: map just logging env wildcards to . by shawkins · Pull Request #40834 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: map just logging env wildcards to . #40834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

fix: map just logging env wildcards to . #40834

merged 2 commits into from
Jul 2, 2025

Conversation

shawkins
Copy link
Contributor
@shawkins shawkins commented Jul 1, 2025

closes: #40833

@shawkins shawkins requested review from a team as code owners July 1, 2025 14:02
mabartos
mabartos reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor
@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Overall LGTM and agree with defaulting to - instead of ..

Just added a few small suggestions.

@shawkins
fix: map just logging env wildcards to .
abf707f 
closes: keycloak#40833

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
updates based upon review comments
16dd080 
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
mabartos
mabartos approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor
@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins LGTM, thanks!

@mabartos mabartos merged commit 3760e72 into keycloak:main Jul 2, 2025
80 checks passed
@mabartos
Copy link
Contributor
mabartos commented Jul 2, 2025

@shawkins Could you please create a backport for 26.3 ?

shawkins added a commit to shawkins/keycloak that referenced this pull request Jul 2, 2025
@shawkins
fix: map just logging env wildcards to . (keycloak#40834)
d040536 
* fix: map just logging env wildcards to .

closes: keycloak#40833

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* updates based upon review comments

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 3760e72)
@shawkins
Copy link
Contributor Author
shawkins commented Jul 2, 2025

@shawkins Could you please create a backport for 26.3 ?

#40865

mabartos pushed a commit that referenced this pull request Jul 2, 2025
@shawkins
fix: map just logging env wildcards to . (#40834) (#40865)
1e6ef59 
* fix: map just logging env wildcards to .

closes: #40833



* updates based upon review comments



---------


(cherry picked from commit 3760e72)

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabartos mabartos mabartos approved these changes

Assignees
No one assigned
Labels
team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change database wildcards to default to - instead of .
2 participants
@shawkins @mabartos
0