implementing json patch #40904
Draft
implementing json patch #40904
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar
reviewed
Jul 8, 2025
There was a problem hiding this comment.
The changes look good, straightforward enough. My only concern would be the zjsonpatch dependency. It seems more like an internal utility lib for Fabric8 rather than something truly standalone (e.g. there doesn't seem to be any docs etc.). I would be worried if we could truly rely on it (in terms of breaking changes, or if it simply doesn't disappear with the next Fabric8 release). Or it's not that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keycloak/cloud-native this is roughly what json patch support looks like. We would also need to put the fabric8 zjsonpatch dependency in the lib.
If we don't want the additional dependency, the alternative is to support jakarta.json / parsson (coming from Quarkus) - that seems slightly less efficient as we'll need to convert back and forth from the JsonValue representation.
Let me know what you think.