Do not add steps if feature disabled in default flows #40964
+51
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow login if a step is disabled even the authenticator is not enabled by profile Closes keycloak#40954 Signed-off-by: rmartinc <rmartinc@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow login if a step is disabled even the authenticator is not enabled by profile
Closes #40954
When webauthn and recovery-codes were added to the default forms we didn't think that the features could be disabled. The PR just adds two things:
DefaultAuthenticationFlow.isConditionalAuthenticatorchecks theisEnabledbefore loading the authenticator. This way even having the steps disabled the login is allowed. Test added for this point.