8000 39546/remove kubernetes stack workarounds 26.2 by ryanemerson · Pull Request #40972 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

39546/remove kubernetes stack workarounds 26.2 #40972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

39546/remove kubernetes stack workarounds 26.2 #40972

merged 1 commit into from
Jul 8, 2025
+1 −59

Conversation

ryanemerson
Copy link
Contributor
@ryanemerson ryanemerson commented Jul 7, 2025 •
edited
Loading

Closes #39546

@ryanemerson ryanemerson marked this pull request as ready for review July 7, 2025 16:30
@ryanemerson ryanemerson requested review from a team as code owners July 7, 2025 16:30
@ryanemerson ryanemerson requested a review from ahus1 July 7, 2025 16:30
@ahus1
Copy link
Contributor
ahus1 commented Jul 7, 2025

@pruivo - please review when you have the time. Thanks!

pruivo
pruivo suggested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor
@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion. LGTM.

...c/main/java/org/keycloak/quarkus/runtime/storage/infinispan/jgroups/JGroupsConfigurator.java Outdated
@@ -107,7 +90,6 @@ public static JGroupsConfigurator create(ConfigurationBuilderHolder holder) {
var configurator = new ArrayList<JGroupsStackConfigurator>(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be set back to 2 based on the diff from commit:

5599836#diff-b928b666e8e3c4cba204462c558ee57541362ac9b9fc5a08135ec33358a2cd6dR107

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, updated.

@ryanemerson
Remove kubernetes stack port_range workarounds
c79b5bb 
Closes keycloak#39546

Signed-off-by: Ryan Emerson <remerson@redhat.com>
@ryanemerson ryanemerson fo 8000 rce-pushed the 39546/remove_kubernetes_stack_workarounds_26.2 branch from fd67f7a to c79b5bb Compare July 8, 2025 08:09
ahus1
ahus1 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews

@ahus1 ahus1 merged commit f3105e7 into keycloak:release/26.2 Jul 8, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
team/cloud-native team/sre
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanemerson @ahus1 @pruivo
0