8000 Make passkeys feature dependent on web_authn by rmartinc · Pull Request #40976 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make passkeys feature dependent on web_authn #40976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make passkeys feature dependent on web_authn #40976

wants to merge 1 commit into from
+1 −1

Conversation

rmartinc
Copy link
Contributor
@rmartinc rmartinc commented Jul 7, 2025 •
edited
Loading

Closes #40975

Adding web_authn dependency to passkeys. passkeys doesn't work without web_authn so better add the dependency.

@rmartinc rmartinc requested a review from a team as a code owner July 7, 2025 16:24
tnorimat
tnorimat reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor
@tnorimat tnorimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By following conventions of other features like

        ADMIN_V2("New Admin Console", Type.DEFAULT, 2, Feature.ADMIN_API),
        ADMIN_FINE_GRAINED_AUTHZ_V2("Fine-Grained Admin Permissions version 2", Type.DEFAULT, 2, Feature.AUTHORIZATION),
        ACCOUNT_V3("Account Console version 3", Type.DEFAULT, 3, Feature.ACCOUNT_API),

How about the following?

        PASSKEYS("Passkeys", Type.PREVIEW, Feature.WEB_AUTHN),

@rmartinc
Make passkeys feature dependent on web_authn
df07419 
Closes keycloak#40975

Signed-off-by: rmartinc <rmartinc@redhat.com>
@rmartinc
Copy link
Contributor Author
rmartinc commented Jul 8, 2025

Yep @tnorimat, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorimat tnorimat tnorimat left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make passkeys feature dependent on web_authn
2 participants
@rmartinc @tnorimat
0