8000 Fix NPE during external-internal token exchange in case that user exists by mposolda · Pull Request #40105 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix NPE during external-internal token exchange in case that user exists #40105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Fix NPE during external-internal token exchange in case that user exists #40105

merged 1 commit into from
May 31, 2025

Conversation

mposolda
Copy link
Contributor

closes #40104

@mposolda mposolda requested review from a team as code owners May 30, 2025 15:58
@mposolda mposolda self-assigned this May 30, 2025
pedroigor
pedroigor previously approved these changes May 30, 2025
View reviewed changes
@pedroigor
Copy link
Contributor

LGTM.

But I'm wondering if we really want to update the email when doing token exchanges? Perhaps it makes more sense to skip it ...

@mposolda
Copy link
Contributor Author

LGTM.

But I'm wondering if we really want to update the email when doing token exchanges? Perhaps it makes more sense to skip it ...

That works for me. Updated the PR. Used separate commit, but I can squash during the merge. What do you think?

pedroigor
pedroigor approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor
@pedroigor pedroigor left a comment

Choose a reason for hiding thi 8000 s comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this was the behavior before my last change to email/verification in brokering.

@mposolda mposolda force-pushed the 40104-external-internal-te-npe branch from fa10d4c to a428ce8 Compare May 30, 2025 21:02
@mposolda mposolda merged commit a66f7fb into keycloak:main May 31, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroigor pedroigor pedroigor approved these changes

Assignees

@mposolda mposolda

Labels
team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE during external-internal token exchange in case that user exists
2 participants
@mposolda @pedroigor
0