8000 Added new searchByAttributes function to UsersResource with the exact parameter by Michael-AT-Corporation · Pull Request #40168 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added new searchByAttributes function to UsersResource with the exact parameter #40168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Added new searchByAttributes function to UsersResource with the exact parameter #40168

merged 1 commit into from
Jul 3, 2025

Conversation

Michael-AT-Corporation
Copy link

Closes #39609

@Michael-AT-Corporation Michael-AT-Corporation requested review from a team as code owners June 2, 2025 17:14
@Michael-AT-Corporation Michael-AT-Corporation mentioned this pull request Jun 2, 2025
Closed
2 tasks
@pedroigor
Copy link
Contributor

Hi @Michael-AT-Corporation, sorry for the delay ....

I've updated your PR to include a note in the upgrade guide as well as small updates to the test.

Thanks again for your contribution.

pedroigor
pedroigor previously approved these changes Jun 30, 2025
View reviewed changes
@pedroigor pedroigor enabled auto-merge (rebase) June 30, 2025 14:23
@ahus1 ahus1 disabled auto-merge June 30, 2025 14:31
ahus1
ahus1 requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KC 26.3 release branch has already been created, so this will end up in 26.4. This needs to be reflected by moving the upgrading guide notes to a new file.

@pedroigor
Copy link
Contributor

@ahus1 Can I send a PR to 26.3 release branch as well?

@ahus1
Copy link
Contributor
ahus1 commented Jun 30, 2025

@pedroigor - even if you send a PR to the 26.3 release branch, it will IMHO not be part of the 26.3.0 release, but 26.3.1 - and then it will again need its own upgrading guide. You'll need to check with @pskopek as AFAIK the release of 26.3.0 is in progress already.

@pedroigor pedroigor force-pushed the 39609 branch 2 times, most recently from a024a2f to a793a13 Compare June 30, 2025 14:38
@pedroigor
Copy link
Contributor

@ahus1 can you please re-review?

ahus1
ahus1 previously approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading guide now looks good.

@ahus1
Copy link
Contributor
ahus1 commented Jun 30, 2025

Upgradng guide now looks good

... one could argue a bit more if you plan to backport it to earlier releases. Still I won't start that.

pedroigor
pedroigor previously approved these changes Jul 3, 2025
View reviewed changes
@pedroigor
Added new searchByAttributes function to UsersResource with the exact…
2735657 
… parameter

Closes keycloak#39609

Signed-off-by: Michael-AT-Corporation <michael-hu@ooutlook.de>
@pedroigor pedroigor merged commit ff9e7c2 into keycloak:main Jul 3, 2025
76 checks passed
@Michael-AT-Corporation
Copy link
Author

@pedroigor Thanks for your help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroigor pedroigor pedroigor approved these changes

@ahus1 ahus1 ahus1 left review comments

Assignees
No one assigned
Labels
team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users searchAttributes broken for empty value
3 participants
@Michael-AT-Corporation @pedroigor @ahus1
0