8000 [OID4VCI]: Add a unique notification_id generation to OID4VCIssuerEndpoint used in CredentialResponse. by Ogenbertrand · Pull Request #40229 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[OID4VCI]: Add a unique notification_id generation to OID4VCIssuerEndpoint used in CredentialResponse. #40229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[OID4VCI]: Add a unique notification_id generation to OID4VCIssuerEndpoint used in CredentialResponse. #40229

wants to merge 7 commits into from
+44 −2

Conversation

Ogenbertrand
Copy link
Contributor

This PR aims at returning a notification_id in credential responses to support issuance flows that can contain more than one credential(OPTIONAL).
Closses: #39284

@Ogenbertrand Ogenbertrand requested review from a team as code owners June 4, 2025 08:16
@Ogenbertrand Ogenbertrand mentioned this pull request Jun 4, 2025
Open
@Ogenbertrand
Add notification_id generation to OID4VCIssuerEndpoint with dedicated…
553eebe 
… generateNotificationId method and test

Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
@Ogenbertrand
fix code format and removed repeating tests
8ff5e64 
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
@Ogenbertrand
generate a uniques notifcation id use in credential response.
79460da 
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
@Ogenbertrand
Merge branch 'main' into issue-39284
6014c0b
@Ogenbertrand
fix failing workflow
e582efa 
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
@Ogenbertrand Ogenbertrand changed the title Add a unique notification_id generation to OID4VCIssuerEndpoint used in CredentialResponse. [OID4VCI]: Add a unique notification_id generation to OID4VCIssuerEndpoint used in CredentialResponse. Jun 19, 2025
@Ogenbertrand
resolve merge conflicts
267cd3e 
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 25, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.RoleInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@mposolda mposolda self-assigned this Jul 7, 2025
mposolda
mposolda previously approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor
@mposolda mposolda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ogenbertrand @francis-pouatcha Thanks for the PR and review!

I hope to merge the PR, but it will need to be rebased due the conflict.
@Ogenbertrand Could you please rebase?

@mposolda mposolda added the status/ready Ready to be merged label Jul 7, 2025
@Ogenbertrand
fix merge conflicts
b395bc3 
Signed-off-by: Ogenbertrand <ogenbertrand@gmail.com>
@Ogenbertrand Ogenbertrand requested a review from mposolda July 7, 2025 15:08
tnorimat
tnorimat approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor
@tnorimat tnorimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@francis-pouatcha francis-pouatcha francis-pouatcha approved these changes

@tnorimat tnorimat tnorimat approved these changes

@mposolda mposolda Awaiting requested review from mposolda

At least 1 approving review is required to merge this pull request.

Assignees

@mposolda mposolda

Labels
flaky-test status/ready Ready to be merged team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ogenbertrand @mposolda @francis-pouatcha @tnorimat
0