8000 fix: avoid double-submission in password change and recovery code scr… by jackie-linz · Pull Request #40263 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: avoid double-submission in password change and recovery code scr… #40263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix: avoid double-submission in password change and recovery code scr… #40263

merged 1 commit into from
Jun 6, 2025

Conversation

jackie-linz
Copy link
Contributor

fixes #39759

These 2 screens could potentially be the last screen before the user gets authenticated. So a double submission would result in a ModelDuplicateException when the 2 submissions gets processed at the same time, and an error for the end user.

@jackie-linz jackie-linz requested review from a team as code owners June 5, 2025 03:59
@ahus1
Copy link
Contributor
ahus1 commented Jun 5, 2025

@jackie-linz - can you please add a sign-off to your commit as outlined in the CONTRIBUTING.md file in the repository?

The "Test OLM" test is unfortunately flaky, see #40099 and we're working on it. I'll try to find some time later this week to see why the Forms IT test fails as it might be related to the changes in this PR.

@jackie-linz
fix: avoid double-submission in password change and recovery code scr…
7b29009 
…eens

Signed-off-by: Jackie Weng <jweng@linz.govt.nz>
@jackie-linz jackie-linz force-pushed the fix/double-submission branch from e91d996 to 7b29009 Compare June 5, 2025 21:22
@jackie-linz
Copy link
Contributor Author

@jackie-linz - can you please add a sign-off to your commit as outlined in the CONTRIBUTING.md file in the repository?

The "Test OLM" test is unfortunately flaky, see #40099 and we're working on it. I'll try to find some time later this week to see why the Forms IT test fails as it might be related to the changes in this PR.

commit updated. looks better now?

Forms IT test passed too - looks like that is flaky?

@ahus1 ahus1 enabled auto-merge (squash) June 6, 2025 06:42
@ahus1
Copy link
Contributor
ahus1 commented Jun 6, 2025

@jackie-linz - thank you, this now looks good.

Out of curiosity: It seems that you added name for some of the buttons. Can you please elaborate on that?

@ahus1
Copy link
Contributor
ahus1 commented Jun 6, 2025

@ssilvert / @edewit - can yo please review the login form changes? Thanks!

@ahus1 ahus1 merged commit f692add into keycloak:main Jun 6, 2025
75 checks passed
@ahus1
Copy link
Contributor
ahus1 commented Jun 6, 2025

@ssilvert / @edewit - oh, sorry for this, it seems that the GitHub UI confused me and my approval was sufficient to get it merged. Still, if you have comments about this, let me know.

@jackie-linz
Copy link
Contributor Author

@jackie-linz - thank you, this now looks good.

Out of curiosity: It seems that you added name for some of the buttons. Can you please elaborate on that?

@ahus1 the name is needed so that the button can be easily referenced in the onsubmit event handler

the 2 login-recovery-authn-code-input.ftl pages didn't need it, as their submit button is already named login

@jackie-linz jackie-linz mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
team/core-clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModelDuplicateException since Keycloak v26 when logging into Keycloak
3 participants
@jackie-linz @ahus1 @ssilvert
0