Move PartialImportTest.java to the new testsuite #40279
Open
+1,127
−984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: keycloak#34494 Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
vaceksimon
suggested changes
Jul 2, 2025
Comment on lines
+91
to
+93
| protected ClientResource clientRolesClient() { | ||
| return ApiUtil.findClientResourceByName(managedRealm.admin(), CLIENT_ROLES_CLIENT); | ||
| } |
There was a problem hiding this comment.
This method can be replaced with rolesClient.admin()
| @Test | ||
| public void testOverwriteExistingClientWithServiceAccount() { | ||
| setOverwrite(); | ||
| piRep.setClients(Collections.singletonList(managedRealm.admin().clients().findByClientId(CLIENT_SERVICE_ACCOUNT).get(0))); |
There was a problem hiding this comment.
Suggested change
| piRep.setClients(Collections.singletonList(managedRealm.admin().clients().findByClientId(CLIENT_SERVICE_ACCOUNT).get(0))); | |
| piRep.setClients(Collections.singletonList(serviceClient.admin().toRepresentation())); |
Comment on lines
+185
to
+186
| ClientRepresentation client = managedRealm.admin().clients().findByClientId(CLIENT_SERVICE_ACCOUNT).get(0); | ||
| managedRealm.admin().clients().get(client.getId()).getServiceAccountUser(); |
There was a problem hiding this comment.
Suggested change
| ClientRepresentation client = managedRealm.admin().clients().findByClientId(CLIENT_SERVICE_ACCOUNT).get(0); | |
| managedRealm.admin().clients().get(client.getId()).getServiceAccountUser(); | |
| serviceClient.admin().getServiceAccountUser(); |
There was a problem hiding this comment.
Looking at this, I realized how little we use assertDoesNotThrow. Or actually only twice in all the tests. Why is it not used? Wouldn't it make it clearer what should and shouldn't happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #34494