8000 Password modification time attribute as an operational and read-only attribute by pedroigor · Pull Request #40280 · keycloak/keycloak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Password modification time attribute as an operational and read-only attribute #40280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Password modification time attribute as an operational and read-only attribute #40280

merged 1 commit into from
Jun 10, 2025

Conversation

pedroigor
Copy link
Contributor
@pedroigor pedroigor commented Jun 5, 2025 •
edited
Loading

Closes #40270
Closes #40096

@pedroigor pedroigor requested review from a team as code owners June 5, 2025 13:39
@pedroigor pedroigor force-pushed the issue-40270 branch 3 times, most recently from 0c07a21 to 833ae9b Compare June 5, 2025 18:29
@pedroigor pedroigor mentioned this pull request Jun 5, 2025
Closed
2 tasks
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 5, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPReadOnlyTest#testReadOnlyUserGetsPermanentlyLocked

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@pedroigor pedroigor force-pushed the issue-40270 branch 2 times, most recently from 02f1a56 to 44cf94b Compare June 9, 2025 18:19
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.UserInvalidationClusterTest#crudWithoutFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 9, 2025
View reviewed changes
Copy link
@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@pedroigor pedroigor force-pushed the issue-40270 branch 2 times, most recently from 65e5ecf to 216acd1 Compare June 9, 2025 23:10
@pedroigor pedroigor mentioned this pull request Jun 9, 2025
Closed
2 tasks
@pedroigor
Password modification time attribute as an operational and read-only …
618ba97 
…attribute

Closes keycloak#40270

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
@ahus1 ahus1 enabled auto-merge (squash) June 10, 2025 14:28
ahus1
ahus1 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor
@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews

@ahus1 ahus1 merged commit 9412e33 into keycloak:main Jun 10, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@sguilhen sguilhen sguilhen approved these changes

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDAP: error code 19 - pwdChangedTime: no user modification allowed Error creating user in Windows Active Directory over LDAP
3 participants
@pedroigor @sguilhen @ahus1
0