fix: switching to the registry addon for olm testing #40334
Conversation
closes: keycloak#40099 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
| @@ -169,7 +169,7 @@ jobs: | |||
| working-directory: operator | |||
| run: | | |||
| eval $(minikube -p minikube docker-env) | |||
| ./scripts/olm-testing.sh ${GITHUB_SHA::6} | |||
| REGISTRY=192.168.49.2:5000 ./scripts/olm-testing.sh ${GITHUB_SHA::6} | |||
There was a problem hiding this comment.
Is it safe to assume the IP address? Shouldn't we use something like $(minikube ip) instead?
There was a problem hiding this comment.
It already has to be hard-coded in the minikube start --insecure-registries, but yes you could change this spot if you want.
There was a problem hiding this comment.
Do we need to provide the --insecure-registry option? Problem is at that point we can't get the minikube's IP as it's not started yet.
There was a problem hiding this comment.
Do we need to provide the --insecure-registry option?
Yes - https://minikube.sigs.k8s.io/docs/handbook/pushing/#4-pushing-to-an-in-cluster-using-registry-addon
Problem is at that point we can't get the minikube's IP as it's not started yet.
Correct - if we change to a different driver, the ip may change. See that the docs refer you to this code https://github.com/kubernetes/minikube/blob/dfd9b6b83d0ca2eeab55588a16032688bc26c348/pkg/minikube/cluster/cluster.go#L408
There was a problem hiding this comment.
Ok, let's keep as is and we'll reconsider if it breaks.
|
I think we could also backport to 26.2. |
closes: keycloak#40099 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit eb96b4a)
|
closes: keycloak#40099 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit eb96b4a)
…keycloak#40349) closes: keycloak#40099 (cherry picked from commit eb96b4a) Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 9e6e9e3)
Just relying upon the docker daemon is not possible - while you can workaround several opm / olm issues, you can't install the CatalogSource with an imagepullpolicy of IfNotPresent unless you have an image digest - and those are only created by a registry.
So the approach here is to use the registry addon. However I do see that it doesn't always work as expected with minikube (1.32.0 seems fine, but locally minikube 1.35.0 won't start with registry addon enabled). Hopefully we can stick to minikube / kubernetes combinations where all is good, but if not we'll then have to deploy or run an external registry, which has a couple of extra steps.
closes: #40099