-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Integrate passkeys with separate username and password forms #40371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes keycloak#40021 Signed-off-by: rmartinc <rmartinc@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailoverKeycloak CI - Store IT (mariadb)
|
@rmartinc Approving, Thanks! There are probably some corner-cases when the behaviour might not be the desired one (For example when usernameForm and passwordForm are not at the same level, but in some different subflows of the authentication flow). But IMO great for now. |
Hi @mposolda for the pending change that I proposed 2 weeks ago, the best way is to create a new issue ? |
@Romain7495 What change are you referring to? |
@Romain7495 Yep, create a new issue, I didn't think or test that scenario. |
@Romain7495 I have created #40717, I'll send a PR asap. |
Sorry I saw your message too late @rmartinc Thanks! |
Closes #40021
PR to add passkeys to the separate username and password form authenticators. This PR follows the same idea used in the previous issue but it needs two more things:
success(String)
to mark the authenticator succeeded and it was used the passed credetial (otp, webauthn, cert, password,...). That type is added to the auth session in an attributelast.authn.credential
.Tests added in a similar way of the previous PRs.