Remove obsolete information from the Keycloak deployment #40376
Conversation
Closes keycloak#40375 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
|
@ryanemerson - can you please review this issue when you have the time? The YAML files contain a lot of changes, but the rendered docs only show some slightly changed Keycloak deployment. Thanks! |
| configListener: | ||
| enabled: false | ||
| container: | ||
| extraJvmOpts: '-Dorg.infinispan.openssl=false -Dinfinispan.cluster.name=ISPN -Djgroups.xsite.fd.interval=2000 -Djgroups.xsite.fd.timeout=15000' | ||
| extraJvmOpts: '-Dorg.infinispan.openssl=false -Dorg.infinispan.threads.virtual=true -Dinfinispan.cluster.name=ISPN -Djgroups.xsite.fd.interval=2000 -Djgroups.xsite.fd.timeout=15000 -Dotel.traces.sampler=parentbased_always_off' |
There was a problem hiding this comment.
-Dorg.infinispan.threads.virtual=true is redundant now as we enable by default if there is sufficient parallelism. We should probably remove this from keycloak-benchmark so that it does not make it into the Keycloak docs when we copy over the files.
There was a problem hiding this comment.
I didn't realise we didn't show the extraJvmOpts, so this isn't really a concern.
There was a problem hiding this comment.
... and I just remembered we're deploying Infinispan separately, so it is in fact needed until infinispan/infinispan#14579 lands in 16 🙃
Should we be including this property in the example Infinispan CRs given this is what we're testing with?
There was a problem hiding this comment.
AFAIK it is not officially supported in RHDG, so I'd say no.
|
@mhajas - can you please approve this PR based on Ryan's review? Thanks! |
Closes #40375