8000 Test double initialization of adapter by jonkoops · Pull Request #137 · keycloak/keycloak-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test double initialization of adapter #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

jonkoops
Copy link
Contributor
@jonkoops jonkoops commented Jul 8, 2025

Closes #14

Closes keycloak#14

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops requested review from a team and Copilot July 8, 2025 12:29
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test to verify that attempting to initialize the adapter more than once throws the expected error, closing issue #14.

  • Introduces a Playwright spec to confirm double initialization is disallowed.
  • Validates that executor.initializeAdapter() rejects with the correct error message on second call.

Copy link
Contributor
@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonkoops! LGTM!

@jonkoops jonkoops merged commit bc3f761 into keycloak:main Jul 8, 2025
4 checks passed
@jonkoops jonkoops deleted the test-double-init branch July 8, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for calling init() more than once
2 participants
0