8000 feat: Function pointers (Fixes #20) by keyvank · Pull Request #37 · keyvank/30cc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Function pointers (Fixes #20) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2024
8000 Merged

feat: Function pointers (Fixes #20) #37

merged 4 commits into from
Nov 2, 2024

Conversation

keyvank
Copy link
Owner
@keyvank keyvank commented Nov 1, 2024

Fixes #20

@keyvank
Copy link
Owner Author
keyvank commented Nov 1, 2024

@amiremohamadi Would you review? :) I'm gonna add you to the maintainers list!

@keyvank keyvank requested a review from Glyphack November 1, 2024 19:06
@amiremohamadi
Copy link
Collaborator

oh sure! i'll do a review tonight. sorry for the delay, must've missed the notification

@amiremohamadi
Copy link
Collaborator

@keyvank amazing work! Just a small suggestion (not specifically related to this change):

IMO it's generally better to return from functions instead of using exit() directly, as this helps ensure that allocated memory is properly freed. we can do that along with #36.

lgtm, let's merge this PR 🍻

@keyvank keyvank merged commit 4c17641 into main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glyphack Glyphack Glyphack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pointer-to-functions
3 participants
@keyvank @amiremohamadi @Glyphack
0