8000 fix graph node size metric · Issue #8430 · kiali/kiali · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix graph node size metric #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmazzitelli opened this issue May 17, 2025 · 1 comment · Fixed by #8432
Closed

fix graph node size metric #8430

jmazzitelli opened this issue May 17, 2025 · 1 comment · Fixed by #8432
Assignees
@jmazzitelli
Labels
bug Something isn't working

Comments

@jmazzitelli
Copy link
Collaborator
jmazzitelli commented May 17, 2025 •
edited
Loading

The graph node size metric was changed to always be 0 for some reason: 667a887

Let's fix that. We need to set the number of nodes in the graph at these 2 points in the code (lines 40 and 76 here): https://github.com/kiali/kiali/blob/v2.9.0/graph/api/api.go#L40-L76

Instead of "0" we need the size of the graph (i.e. the number of nodes in the graph).

This is part of #8348
@jmazzitelli jmazzitelli added the bug Something isn't working label May 17, 2025
@jmazzitelli
Copy link
Collaborator Author

From @jshaughn:

It's a little bit of a pain because at the point of the metric setting we have an anonymous type. But since we really only have one config vendor [mazz: now that Cytoscape is gone, I assume we only have one now], this should always work:

	numNodes := 0
	if _, ok := graphConfig.(config_common.Config); ok {
		numNodes = len(graphConfig.(config_common.Config).Elements.Nodes)
	}
	internalmetrics.SetGraphNodes(o.GetGraphKind(), o.TelemetryOptions.GraphType, o.InjectServiceNodes, numNodes)

jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue May 17, 2025
@jmazzitelli
get node count and set the graph node metric
0ed0f78 
fixes: kiali#8430
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue May 17, 2025
@jmazzitelli
get node count and set the graph node metric
7bc795b 
fixes: kiali#8430
@jmazzitelli jmazzitelli mentioned this issue May 17, 2025
Merged
jmazzitelli added a commit that referenced this issue May 18, 2025
@jmazzitelli
get node count and set the graph node metric (#8432)
0d4b4d5 
fixes: #8430
@jmazzitelli jmazzitelli self-assigned this May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazzitelli jmazzitelli

Labels
bug Something isn't working
Projects
Kiali Sprint 25-08 | Kiali v2.11
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix graph node size metric jmazzitelli/kiali
1 participant
@jmazzitelli
0