10000 Throw error when grouping by an unknown column (closes #81) by crew102 · Pull Request #82 · kieferk/dfply · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Throw error when grouping by an unknown column (closes #81) #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw error when grouping by an unknown column (closes #81) #82

wants to merge 1 commit into from

Conversation

crew102
Copy link
Contributor
@crew102 crew102 commented Feb 8, 2019

One quick note: I put assert_known_cols() inside group_by() instead of within group_delegation.__call__() b/c I wanted the error to be thrown even if no grouped function is called on the data. In other words, I wanted there to be an error when running code like this:

x = diamonds >> group_by('bad_col')
@crew102 crew102 changed the title Throw error when grouping by an unknown column (closes #17) Throw error when grouping by an unknown column (closes #81) Feb 8, 2019
@crew102
Copy link
Contributor Author
crew102 commented Feb 8, 2019

FYI, this is failing on Travis b/c Python 3.7 can't be installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crew102
0