置顶memo筛选处理 #286
Merged
置顶memo筛选处理 #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuewenG
reviewed
Feb 17, 2025
|
辛苦了，今天晚上会 review 一下 |
|
看起来这个 PR 先分页再排序置顶，如果被置顶的 memo 不在当前页，是否会被漏掉？即，如果 memo 的数量大于 1 页时，将最早发布的 memo 置顶后，并不能在第 1 页的头部看见。 |
你说得对，这是我的疏忽。我准备修改一下。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么？
fix #262
原memo列表的逻辑为：只筛选未置顶memo，置顶memo固定置顶展示。
改为：筛选所有memo，若仍有置顶memo再置顶展示。
测试镜像:
jinvic/moments:test