Using the objective-c default return type id instead of void for stubbed methods #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just wondering, do you think it would make sense to write a test for this one? |
|
I added a unit test for this. The scenario that lead me to the changes in this PR is the following:
This also happens if I try to mock a class that implements several protocols, as the KWMock constructor allows either a class, or a single protocol. |
supermarin
added a commit
that referenced
this pull request
Oct 18, 2013
Using the objective-c default return type id instead of void for stubbed methods
|
@cristiankocza nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective-c's default return type is id. Currently Kiwi generates method signatures with the "void" return type if the stubbed method is not found within the mocked class/protocol.