8000 SQLite fixes by aumetra · Pull Request #183 · kitsune-soc/kitsune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SQLite fixes #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2023
Merged

SQLite fixes #183

merged 3 commits into from
Apr 16, 2023

Conversation

aumetra
Copy link
Member
@aumetra aumetra commented Apr 15, 2023

Small fixes for SQLite

  1. The select was broken. We called select_only but no column to select
  2. A transaction in SQLite locks the whole database, then we tried to enqueue the job via a separate database connection. This will obviously fail after the timeout since this would be a double lock. To fix this, I simply moved the job enqueueing outside of the transaction.
    I think this is fine because the post is in a complete state. It not being federated isn't really a concern of the transaction.

Thanks to s4if on Matrix for reporting these issues

@aumetra aumetra merged commit a738eeb into main Apr 16, 2023
@aumetra aumetra deleted the aumetra/sqlite-fixes branch April 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aumetra
0