[pull] main from Ultimaker:main #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… center. In isolation, you'd really want the actual closest point on the polygon, however, that'd make the seams not fit together for polygons with different sizes and shapes, especially if rounding is involved. start of CURA-11974 (split off from CURA-9474).
…rst, and disable for shortest. Since as polygons shift over the players, their center also changes, we need to be careful to get the same point each time (or at least try to, since if it's not the polygon center anymore but that of the entire model, the intersection with the line from that center to the requested point might not exist). Also disable _any_ of this new behaviour (also the previously introduced) for the 'shortest.' part of CURA-11974
Otherwise the algo would still occasionally choose other vertices, despite there being only one that we actually want it to land on. This would make the seams look messy in 3D space. part of CURA-11974
The infill overlap previously worked by extending the whole infill area and filling it. However, infill areas sometimes have inner walls, and in this case we would expand the walls, but the pattern generated inside would not overlap the walls, which is actually what we want to achieve in order to ensure that the sparser inner pattern properly sticks to what is outside it, whenever this is an infill wall or a skin wall.
We now try to insert the nozzle switch retract at the same time as the travel move to the nozzle switch position, to avoid oozing during this (long) move. If there is no such move, it will fallback to the old behavior, but this should quite never happen. CURA-11796
Throwing exceptions means you rely on the code around that to be set up for that, which it currently is not. If we only want to know where it crashed, then we can just rely on SIGFPE to be signalled on division-by-zero (which is almost the only case where FPE happens anyway).
…GcodeModifyPatches
Most of the tests where going wrong because the z-height introduced for the scarf seam introduced a refactor that used a variable before it had the correct assignment. part of CURA-12081
In the previous spike, the 'travel_to_z' argument was added (at the end), causing the need for previously omitted (default) parameters to be added as well. In this case, 'spiralize' was omitted, causing the FAN_SPEED_DEFAULT (which is an enum set to -1) to be interpreted as a speed_factor instead. part of CURA-12081
The coasting functionality previously relied (partially) on paths being their own 'complete' extrusions, in between wich where (presumably, mostly) travels. So it only coasted on the last path before a travel, and didn't take into account paths that where to short to complete the full coast (it didn't continue on to the next). This commit fixes that partially -- the volume already coasted isn't taken into account yet, but otherwise it should work as before, but then with the split paths the scarf and accellleration start/end introduced. part of CURA-12081
If, due to the compensation for the paths being split (because of scarf-seams or introduced start/end acceleration-changes), the next path(s) in the 'chunk' are already going to be comletely gone due to coasting, coast less than the 'full' volume for the remainder. part of CURA-12081
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
This reverts commit 54609c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )