8000 Add chainConfigAt, modify chainConfig by ian0371 · Pull Request #510 · klaytn/klaytn-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Add chainConfigAt, modify chainConfig #510

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Add chainConfigAt, modify chainConfig #510

merged 3 commits into from
Dec 27, 2022

Conversation

ian0371
Copy link
Contributor
@ian0371 ian0371 commented Nov 25, 2022

Proposed changes

  • introduce new governance_chainConfigAt()
  • update chainConfig description

FYI, see klaytn/klaytn#1704

Types of changes

Please put an x in the boxes related to your change.

  • Minor Issues and Typos
  • Major Content Contribution
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES
  • I have signed the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large content contribution, kick off the discussion by explaining why you would suggest the content contribution, etc...

8000
@ian0371 ian0371 requested a review from blukat29 November 25, 2022 04:41
@CLAassistant
Copy link
CLAassistant commented Nov 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
github-actions bot commented Nov 25, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ian0371
Copy link
Contributor Author
ian0371 commented Nov 25, 2022

I have read the CLA Document and I hereby sign the CLA

blukat29
blukat29 reviewed Nov 25, 2022
View reviewed changes
@kjhman21
Copy link

This will be merged after v1.10 release

@ian0371 ian0371 self-assigned this Dec 2, 2022
@ian0371 ian0371 merged commit 24e718f into master Dec 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 left review comments

@jiwon-lieb jiwon-lieb jiwon-lieb approved these changes

@0xxlegolas 0xxlegolas 0xxlegolas approved these changes

@kjhman21 kjhman21 Awaiting requested review from kjhman21

@neoofkaia neoofkaia Awaiting requested review from neoofkaia

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

@terry-klaytn terry-klaytn Awaiting requested review from terry-klaytn

@tantely-klaytn tantely-klaytn Awaiting requested review from tantely-klaytn

@praveen-kaia praveen-kaia Awaiting requested review from praveen-kaia

@ayo-klaytn ayo-klaytn Awaiting requested review from ayo-klaytn ayo-klaytn is a code owner

Assignees

@ian0371 ian0371

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ian0371 @CLAassistant @kjhman21 @blukat29 @jiwon-lieb @0xxlegolas
0